Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add docs for deprecated namespace pubsub topic #131

Closed
danisharora099 opened this issue Nov 3, 2023 · 1 comment · Fixed by #193
Closed

feat: add docs for deprecated namespace pubsub topic #131

danisharora099 opened this issue Nov 3, 2023 · 1 comment · Fixed by #193

Comments

@danisharora099
Copy link
Contributor

danisharora099 commented Nov 3, 2023 •
edited
Loading

  • changes the create${xyz}Node() API to take in ShardInfo instead of a PubsubTopic
    • if shardInfo is not provided, it falls back to the DefaultPubsubTopic
  • changes the createEncoder and createDecoder API to take in ShardInfo optionally
    • if a value is not provided, the DefaultPubsubTopic is used
  • changes filter.createSubscription() to take in SingleShardInfo optionally instead of a string
    • if no shard info is passed, the DefaultPubsubTopic is used

reference: waku-org/js-waku#1697
@danisharora099 danisharora099 mentioned this issue Nov 3, 2023
Merged
2 tasks
@LordGhostX LordGhostX mentioned this issue Nov 6, 2023
Closed
8 tasks
@danisharora099
Copy link
Contributor Author

danisharora099 commented Nov 28, 2023 •
edited
Loading

@LordGhostX heads up that the js-waku PR has been merged

@LordGhostX LordGhostX mentioned this issue May 13, 2024
Merged
@LordGhostX LordGhostX linked a pull request May 25, 2024 that will close this issue
chore(js-waku)!: update API for NetworkConfig #193
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Waku
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(js-waku)!: update API for NetworkConfig waku-org/docs.waku.org
1 participant
@danisharora099