Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Showcase page #446

Merged
merged 78 commits into from
Apr 18, 2024
Merged

Add Showcase page #446

merged 78 commits into from
Apr 18, 2024

Conversation

William-Blackie
Copy link
Contributor

@William-Blackie William-Blackie commented Dec 20, 2023 •
edited
Loading

Hey all this PR creates the latest page type; a Showcase page.

Figma:

What I've done:

  • Created a page listing of related models, with Sector snippets used to filter said listing.
  • Create Sector snippets.
  • Added HTMX for AJAX functionality of the listing itself as well as using it to create on-click listeners for the cards; this method is more accessible than wrapping each card in an anchor tag.
  • Added styling and fixed some existing.
  • Added a new SVG for "open-link"
  • Adds pagination

Screenshots:

Mobile (light)

mobile-light

Mobile (dark)

mobile-dark

Tablet (light)

tablet-light

Tablet (dark)

tablet-dark

Desktop (light)

desktop-light

Desktop (dark)

desktop-darkry>

nicklee and others added 19 commits July 20, 2023 14:26
@nicklee
rejig footer
5eae40e
@nicklee
Merge branch 'feature/dark-mode' into staging
b65f257
@nicklee
Merge branch 'feature/dark-mode' into staging
29ed912
@nicklee
Merge branch 'feature/dark-mode' into staging
35f4716
@nicklee
cookie dark mode
f49f137
@nicklee
Merge branch 'feature/dark-mode' into staging
cf97965
@nicklee
this week in wagtail
ee8ba60
@nicklee
Merge branch 'feature/dark-mode' into staging
27f69ac
@nicklee
Merge branch 'feature/dark-mode' into staging
627b979
@nicklee
px to rem
ea3c8db
@nicklee
Merge branch 'feature/dark-mode' into staging
4b9eb8e
@nicklee
removing lint disable
25451ff
@nicklee
Merge branch 'feature/dark-mode' into staging
fc22ca8
@nicklee
Merge branch 'feature/dark-mode' into staging
a65c823
@nicklee
Merge branch 'feature/dark-mode' into staging
cf1f6bf
@nicklee
Merge branch 'feature/dark-mode' into staging
fffdd75
@nicklee
Merge branch 'feature/dark-mode' into staging
d04705e
@nicklee
updating logo card to use bg colour
d9da4b1
@zerolab
Install and enable image optimizer binaries
cbcc59c
zerolab
zerolab requested changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@zerolab zerolab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass review. Left a number of suggestions and questions

wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/core/models/pages.py Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page_fragment.html Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page_fragment.html Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page_fragment.html Outdated Show resolved Hide resolved
@William-Blackie William-Blackie marked this pull request as ready for review December 21, 2023 16:02
@vossisboss vossisboss temporarily deployed to wagtail-org-staging March 15, 2024 19:15 Inactive
@vossisboss vossisboss temporarily deployed to wagtail-org-staging March 15, 2024 19:20 Inactive
@vossisboss vossisboss temporarily deployed to wagtail-org-staging March 15, 2024 19:21 Inactive
@vossisboss vossisboss requested a review from thibaudcolas March 15, 2024 19:47
@vossisboss
Copy link
Contributor

@zerolab and/or @thibaudcolas This branch is ready for review if either of you are available to provide a second pair of eyes on it. Please note that the HTMX was removed due to the bug I reported above. A test showcase page is available on the staging site as well if you would like to look at it. I also haven't rebased the branch yet. I'd like to know if any other big changes are needed before I do that.

thibaudcolas
thibaudcolas reviewed Mar 21, 2024
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backend code review – switching over to the front-end after.

One extra point to check: Migrations – not sure if we have a policy to squash all the schema changes into the initial migration for something like this? Noting this is on staging already though.

wagtailio/showcase/models.py Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page.html Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page.html Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page.html Outdated Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page.yaml Show resolved Hide resolved
wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page.yaml Outdated
- Charity
- Education
- Government
- Media
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn’t seem like it’d ever work based on the template

wagtailio/project_styleguide/templates/patterns/pages/showcase_page/showcase_page_fragment.yaml Show resolved Hide resolved
wagtailio/showcase/models.py Outdated Show resolved Hide resolved
wagtailio/static/js/main.js Outdated Show resolved Hide resolved
@thibaudcolas thibaudcolas merged commit 651efb3 into main Apr 18, 2024
3 checks passed
@thibaudcolas thibaudcolas deleted the showcase-page branch April 18, 2024 13:54
Stormheg pushed a commit that referenced this pull request Jun 23, 2024
@William-Blackie @nicklee
@zerolab @vossisboss @thibaudcolas @Stormheg
Add Showcase page (#446)
82e6699 
Co-authored-by: Nick Lee <[email protected]>
Co-authored-by: zerolab <[email protected]>
Co-authored-by: William Blackie <>
Co-authored-by: vossisboss <[email protected]>
Co-authored-by: Thibaud Colas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vossisboss vossisboss vossisboss left review comments

@thibaudcolas thibaudcolas thibaudcolas left review comments

@zerolab zerolab zerolab requested changes

@nanuxbe nanuxbe nanuxbe requested changes

Assignees
No one assigned
Labels
component: Backend component: Frontend enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@William-Blackie @vossisboss @zerolab @benenright @thibaudcolas @nanuxbe @nicklee