Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add social fields to API meta fields and add serializer for social image #166

Merged
merged 2 commits into from
Feb 25, 2024
Merged

Add social fields to API meta fields and add serializer for social image #166

merged 2 commits into from
Feb 25, 2024

Conversation

Tijani-Dia
Copy link
Contributor

This PR adds the social fields in the API representation of a model.

@Tijani-Dia Tijani-Dia requested a review from kaedroho June 13, 2022 13:26
thibaudcolas
thibaudcolas approved these changes Feb 25, 2024
View reviewed changes
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

curl http://localhost:8000/api/v2/pages/714/ | gron | grep social_

Result:

json.meta.social_image_url = "https://localhost:8000/media/images/awhy-promo.2e16d0ba.fill-100x100.png";
json.meta.social_text = "";

@thibaudcolas thibaudcolas merged commit 96fc35a into main Feb 25, 2024
3 checks passed
@thibaudcolas thibaudcolas deleted the rendition-url-api branch February 25, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thibaudcolas thibaudcolas thibaudcolas approved these changes

@kaedroho kaedroho Awaiting requested review from kaedroho

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Tijani-Dia @thibaudcolas