Skip to content

Commit

Permalink
Remove aria-roledescription usage
Browse files Browse the repository at this point in the history
  • Loading branch information
thibaudcolas committed Feb 25, 2024
1 parent 69c5b5e commit c1035b6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -3,11 +3,11 @@
<div class="grid">
<div class="hero {% if classes %}{{ classes }}{% endif %}">
<div class="hero__inner">
<hgroup role="group" aria-roledescription="heading group">
<hgroup>
<h1 class="hero__heading">{% firstof value.heading value.title %}</h1>

{% if value.sub_heading or value.subheading %}
<p aria-roledescription="subheading" class="hero__subheading intro-big">{% firstof value.sub_heading value.subheading %}</p>
<p class="hero__subheading intro-big">{% firstof value.sub_heading value.subheading %}</p>
{% endif %}
</hgroup>

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,10 @@
{% include "patterns/components/icon/icon.html" with icon=value.icon classes="icon-link__svg" %}

<div class="icon-link__content">
<hgroup role="group" aria-roledescription="heading group">
<hgroup>
<h3 class="icon-link__heading teaser-heading">{{ value.heading }}</h3>

<p aria-roledescription="subheading" class="icon-link__subheading heading-four">{{ value.subheading }}</p>
<p class="icon-link__subheading heading-four">{{ value.subheading }}</p>
</hgroup>

<p class="icon-link__description mini-meta">{{ value.description }}</p>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,11 @@
{% include "patterns/components/icon/icon.html" with icon=value.icon classes="headline__icon" %}
{% endif %}
<div class="headline__inner">
<hgroup role="group" aria-roledescription="heading group">
<hgroup>
<h2 class="headline__heading heading-one">{{ value.heading }}</h2>

{% if value.sub_heading %}
<p aria-roledescription="subheading" class="headline__subheading intro-big">{{ value.sub_heading }}</p>
<p class="headline__subheading intro-big">{{ value.sub_heading }}</p>
{% endif %}
</hgroup>
{% if value.intro %}
Expand All @@ -26,4 +26,4 @@ <h2 class="headline__heading heading-one">{{ value.heading }}</h2>
{% endif %}
</div>
</div>
</div>
</div>

0 comments on commit c1035b6

Please sign in to comment.