Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch from yarn to npm #58

Merged
merged 2 commits into from
Mar 24, 2021
Merged

Switch from yarn to npm #58

merged 2 commits into from
Mar 24, 2021

Conversation

Stormheg
Copy link
Member

No other Wagtail project uses yarn. Partially address #56.

@Stormheg Stormheg requested a review from thibaudcolas March 20, 2021 20:48
# ATTENTION: Select only those with reasonable version numbers.
# Be very careful if the MAJOR number would change
yarn upgrade-interactive --latest
Use `npm` for package management.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've removed most of this section as npm has no interactive upgrade mechanism as far as I'm aware.

@@ -5,7 +5,6 @@
"dependencies": {},
"devDependencies": {
"@fortawesome/fontawesome-free": "^5.13.0",
"TYPO3CMS-Guide-HowToDocument": "github:TYPO3-Documentation/TYPO3CMS-Guide-HowToDocument",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure what this was being used for. Removed it because it causes npm install to fail.

No other Wagtail project uses yarn.
docs/development.rst Outdated Show resolved Hide resolved
docs/development.rst Outdated Show resolved Hide resolved
Copy link
Member

@thibaudcolas thibaudcolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @Stormheg :)

@thibaudcolas thibaudcolas merged commit a994dbc into main Mar 24, 2021
@thibaudcolas thibaudcolas deleted the switch-to-npm branch March 24, 2021 07:43
lb- pushed a commit to lb-/sphinx_wagtail_theme that referenced this pull request Mar 9, 2022
- also includes some npm package security fixes
- also remove reference to yarn as this is no longer used since wagtail#58
Stormheg pushed a commit to lb-/sphinx_wagtail_theme that referenced this pull request Mar 18, 2022
- also includes some npm package security fixes
- also remove reference to yarn as this is no longer used since wagtail#58
Stormheg added a commit that referenced this pull request Mar 18, 2022
* update node version usage from v14 to v16

- also includes some npm package security fixes
- also remove reference to yarn as this is no longer used since #58

* Add changelog entry for #132

Co-authored-by: LB Johnston <[email protected]>
Co-authored-by: Storm Heg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants