Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the toolbar in Wagtail 4. #39

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fixed the toolbar in Wagtail 4. #39

wants to merge 2 commits into from

Commits on Feb 21, 2023

  1. Applied several fixes to make the fixed-position toolbar work properl… 

    …y on Wagtail 4.

The fixes include:

* Increased the height of the top-padding which gets added when the toolbar appears. This makes room for it always being two rows in Wagtail 4, due to the limited width of rich text editors.
* Removed the .object prefix on the CSS we apply, since Wagtail 4 page editors don't use that class any more.
* Added 44px to the 'top' position set by the JS for the toolbar, to account for the changes in Wagtail 4's editor UI.
* Made the scroll and resize events trigger for both the `window` object and '.content-wrapper', since the window doesn't scroll any more in Wagtail 4. The window events are retained because I think they're still relevant in Wagtail 3.
    @coredumperror
    coredumperror committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    781de04 View commit details
    Browse the repository at this point in the history

  2. Applied required formatting fixes. 

    Reluctantly.
    @coredumperror
    coredumperror committed Feb 21, 2023
    Configuration menu
    Copy the full SHA
    413dc5e View commit details
    Browse the repository at this point in the history