Fix #475 failure to inspect podman://ubuntu:24.04
#476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`IsSet("source")` returned `true` even if `--source` was not specified.
https://github.com/spf13/viper/releases/tag/v1.6.0
The problem was caused by net/url.Parse() panic: parse "podman://docker:23.0.1": invalid port ":23.0.1" after host Testing the fix ✗ ./dive podman://docker:23.0.1 Image Source: podman://docker:23.0.1 ✗ ./dive podman://docker:23.0.1 --source docker Image Source: podman://docker:23.0.1 ✗ ./dive docker:23.0.1 --source podman Image Source: podman://docker:23.0.1
abitrolly
changed the title
docker:23.0.1 with podmanpodman://ubuntu:24.04
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
The problem was caused by `net/url.Parse()`: ``` panic: parse "podman://ubuntu:24.04": invalid port ":24.04" after host ``` Failure: ``` $ ./dive podman://ubuntu:24.04 Image Source: docker://podman://ubuntu:24.04 Fetching image... (this can take a while for large images) Handler not available locally. Trying to pull 'podman://ubuntu:24.04'... cannot fetch image cannot find docker client executable ``` Success: ``` $ ./dive podman://ubuntu:24.04 Image Source: podman://ubuntu:24.04 ... $ ./dive ubuntu:24.04 --source podman Image Source: podman://ubuntu:24.04 ... $ ./dive podman://ubuntu:24.04 --source docker Image Source: podman://ubuntu:24.04 ... ``` Fixes wagoodman#475 Co-authored-by: Anatoli Babenia <[email protected]>
joschi
added a commit
to joschi/dive
that referenced
this pull request
Nov 7, 2024
The problem was caused by `net/url.Parse()`: ``` panic: parse "podman://ubuntu:24.04": invalid port ":24.04" after host ``` Failure: ``` $ ./dive podman://ubuntu:24.04 Image Source: docker://podman://ubuntu:24.04 Fetching image... (this can take a while for large images) Handler not available locally. Trying to pull 'podman://ubuntu:24.04'... cannot fetch image cannot find docker client executable ``` Success: ``` $ ./dive podman://ubuntu:24.04 Image Source: podman://ubuntu:24.04 ... $ ./dive ubuntu:24.04 --source podman Image Source: podman://ubuntu:24.04 ... $ ./dive podman://ubuntu:24.04 --source docker Image Source: podman://ubuntu:24.04 ... ``` Fixes wagoodman#475 Co-authored-by: Anatoli Babenia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #475.
Inspecting
podman://ubuntu:24.04fails with the latest revisiondive.The problem is caused by
net/url.Parse()(https://go.dev/play/p/0fPOA--41-1).Testing the fix