minimum version 내림차순으로 config 정렬하여 처음거 선택 #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asp345
requested review from
davin111,
Hank-Choi and
SeonghaeJo
and removed request for
a team
|
이슈 설명 써주세요 |
SeonghaeJo
reviewed
Oct 9, 2024
| when (osType) { | ||
| OsType.ANDROID -> it.minAndroidVersion | ||
| OsType.IOS -> it.minIosVersion | ||
| else -> it.minAndroidVersion |
There was a problem hiding this comment.
큰 상관은 없을 것 같은데 else 일 때는 createdAt이나 updatedAt으로 정렬하는 건 어떤가요?
SeonghaeJo
approved these changes
Oct 9, 2024
|
https://wafflestudio.slack.com/archives/C0PAVPS5T/p1728473406229769?thread_ts=1728127630.634169&cid=C0PAVPS5T |
|
그런데 DB 보니깐 min version도 없는 경우가 있는데, 이런 경우엔 어떻게 처리되는건가요? |
|
그냥 삽입 시점에 name과 버전이 겹치는 걸 막는게 낫지 않을까요? 이런 경우에 max 가 null이면 새로 삽입을 아예 막도록 해야 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.