Switch to non-reactive mongodb to fix batch #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hank-Choi
reviewed
Sep 3, 2024
Comment on lines
+18
to
+28
| CoroutineScope(Dispatchers.IO).launch { | ||
| runCatching { | ||
| mongoTemplate.updateMulti( | ||
| Query(Criteria.where("_id").`in`(snuttIds)), | ||
| Update().set("evInfo.evId", evInfo?.id) | ||
| .set("evInfo.avgRating", evInfo?.avgRating) | ||
| .set("evInfo.count", evInfo?.count), | ||
| "lectures", | ||
| ) | ||
| } | ||
| } |
There was a problem hiding this comment.
coroutineScope는 빼도 괜찮을 것 같네요.
어차피 이거 webflux 스택이 아니라서요
There was a problem hiding this comment.
코루틴 의존성 떼고 아예 나중에 virtualThread 붙이는게 훨씬 나을듯해요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이렇게 하면 배치가 고쳐지긴 하는데 정확한 이유를 모르겠네요