시설, 찾아오는길 v2 read api + 진로 현황 CU api #323
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huGgW
approved these changes
Oct 6, 2024
Comment on lines
+15
to
+18
| enum class Career(val krName: String) { | ||
| SAMSUNG("삼성"), LG("LG"), LARGE("기타 대기업"), | ||
| SMALL("중소기업"), GRADUATE("진학"), OTHER("기타") | ||
| } |
There was a problem hiding this comment.
이 부분 enum으로 한 이유가 있는거 아니면 그냥 string으로 하는게 나을듯..?
사실 이 부분이 변경될 가능성이 거의 없기야 해서 상관없을거 같긴 하지만
There was a problem hiding this comment.
이상한 값 들어오는 거 방지 + 영어로 받아서 DB에는 기존과 같이 한글로 넣으려고 이렇게 했는데 string으로 하는게 나을거 같은 이유는 어떤 부분이야?
src/main/kotlin/com/wafflestudio/csereal/core/about/dto/FacDto.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/wafflestudio/csereal/core/about/service/AboutService.kt
Show resolved
Hide resolved
src/main/kotlin/com/wafflestudio/csereal/core/about/service/AboutService.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/com/wafflestudio/csereal/core/about/service/AboutService.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
시설, 찾아오는길 + 졸업생 진로 현황
한줄 요약
시설, 찾아오는길 v2 GET api, 졸업생 진로 현황 연도 추가, 연도별 수정 api