feat: scholarship CRUD #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huGgW
reviewed
Aug 16, 2024
src/main/kotlin/com/wafflestudio/csereal/core/academics/api/req/CreateScholarshipReq.kt
Show resolved
Hide resolved
huGgW
reviewed
Aug 16, 2024
src/main/kotlin/com/wafflestudio/csereal/core/academics/api/v1/AcademicsController.kt
Outdated
Show resolved
Hide resolved
huGgW
reviewed
Aug 16, 2024
src/main/kotlin/com/wafflestudio/csereal/core/academics/api/v1/AcademicsController.kt
Show resolved
Hide resolved
huGgW
reviewed
Aug 16, 2024
| fun readScholarship(scholarshipId: Long): ScholarshipDto | ||
| fun readScholarshipV2(scholarshipId: Long): Pair<ScholarshipDto, ScholarshipDto> |
There was a problem hiding this comment.
v2보단 readScholarshipLanguages 등 네이밍이 더 나을거 같긴 하지만 이것도 SASO
leeeryboy
added a commit
that referenced
this pull request
Aug 19, 2024
Merged
leeeryboy
added a commit
that referenced
this pull request
Sep 23, 2024
* 교과목 정렬, 쿠키 secure 옵션 추가 (#308) * feat: 교과목 정렬 * feat: 쿠키 secure 옵션 추가 * referrer policy 헤더 추가 (#311) * referrer policy 헤더 추가 * 헤더 수정 * feat: scholarship CRUD (#309) * feat: scholarship CRUD * 불필요한 라인 삭제 * 리뷰 반영 * Update deploy_dev.yaml * 강의실 예약 제한 (#312) * feat: 소개 탭 CRUD (#314) * feat: 소개 탭 CRUD * fix: 권한 체크 추가 * fix: 동아리 id 기준으로 로직 변경 * fix: 쿠키 same-site: strict * 리뷰 반영 * 리뷰 반영 * 로그인 핫픽스 (#316) * Feat: Research Group & Center 언어포함 CRUD 생성 (#315) * refactor: deprecated v1 controller * refactor: extract types in seperate package, remove unused attachment from research * feat: make lab's research as nullable * feat: add research language entity & repository * feat: add language & sealed dtos * feat: remove migrate methods & seperate update index methods * feat: add CRUD language considered methods * feat: add v2 reserach controller * fix: fix test compiling * test: fix professerservice test * refactor: fix ktlint formatting * review: research -> fetch lazy * Refactor: 구성원 POST API image => mainImage 리펙토링 #317 * Refactor: PUT API newImage => newMainImage 수정 #318 * Feat: Lab CRUD (#319) * feat: add request body * feat: modify dto nullability * feat: extract lab service && implement CRUD * feat: add lab language dto * feat: add lab events * fix: fix unique constraints for research language entity * feat: add methods to repositories * feat: add LAB CRUD APIs * refactor: seperate event services * refactor: professors to mutable var * fix: fix typos * comment: add comment to professor service method * test: remove unneed test file * feat: split search service and event service * feat: implement professor, research event service * fix: apply ktlint * cascade 제거 (#321) * cascade 제거 * 이미지 제거 추가 --------- Co-authored-by: Junhyeong Kim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
장학제도
한줄 요약
장학제도 상위 페이지 수정 api 추가, 개별 장학제도 crud v2 api
TODO
prod 나갈때 scholarship_language 테이블 생성 및 id 연결