Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libsvtvp9 #302

Closed
wants to merge 1 commit into from
Closed

Add libsvtvp9 #302

wants to merge 1 commit into from

Conversation

wader
Copy link
Owner

@wader wader commented Mar 16, 2023

No description provided.

@wader
Copy link
Owner Author

wader commented Mar 21, 2023

TODO: add version to json and to readme, bump config to follow master?

@wader
Copy link
Owner Author

wader commented Mar 23, 2023

libsvt-vp9 fails to build in aarch64, seems like it tries to use x86 asm stuff:

...
2023-03-23T09:58:44.3683449Z #38 2.319 In file included from /SVT-VP9/Source/Lib/ASM_SSE4_1/EbComputeSAD_SSE4_1.h:9,
2023-03-23T09:58:44.3683906Z #38 2.319                  from /SVT-VP9/Source/Lib/ASM_SSE4_1/EbComputeSAD_Intrinsic_SSE4_1.c:6:
2023-03-23T09:58:44.3684393Z #38 2.319 /SVT-VP9/Source/Lib/Codec/EbDefinitions.h:402:10: fatal error: immintrin.h: No such file or directory
2023-03-23T09:58:44.3684797Z #38 2.319   402 | #include <immintrin.h>
2023-03-23T09:58:44.3685024Z #38 2.319       |          ^~~~~~~~~~~~~
2023-03-23T09:58:44.3685435Z #38 2.319 In file included from /SVT-VP9/Source/Lib/ASM_SSSE3/EbIntraPrediction_Intrinsic_SSSE3.c:6:
2023-03-23T09:58:44.3685938Z #38 2.319 /SVT-VP9/Source/Lib/Codec/EbDefinitions.h:402:10: fatal error: immintrin.h: No such file or directory
2023-03-23T09:58:44.3686261Z #38 2.319   402 | #include <immintrin.h>
2023-03-23T09:58:44.3686474Z #38 2.319       |          ^~~~~~~~~~~~~
2023-03-23T09:58:44.3686685Z #38 2.319 compilation terminated.
2023-03-23T09:58:44.3686917Z #38 2.319 compilation terminated.
2023-03-23T09:58:44.3687388Z #38 2.320 make[2]: *** [Source/Lib/ASM_SSSE3/CMakeFiles/VP9_ASM_SSSE3.dir/build.make:79: Source/Lib/ASM_SSSE3/CMakeFiles/VP9_ASM_SSSE3.dir/EbIntraPrediction_Intrinsic_SSSE3.c.o] Error 1
2023-03-23T09:58:44.3688170Z #38 2.321 make[2]: Leaving directory '/SVT-VP9/Build'
2023-03-23T09:58:44.3688572Z #38 2.321 In file included from /SVT-VP9/Source/Lib/ASM_AVX2/EbAvcStyleMcp_AVX2.h:9,
2023-03-23T09:58:44.3689022Z #38 2.321                  from /SVT-VP9/Source/Lib/ASM_AVX2/EbAvcStyleMcp_Intrinsic_AVX2.c:7:
2023-03-23T09:58:44.3689501Z #38 2.321 /SVT-VP9/Source/Lib/Codec/EbDefinitions.h:402:10: fatal error: immintrin.h: No such file or directory

@wader
Copy link
Owner Author

wader commented Mar 23, 2023

@pyldin601
Copy link
Contributor

pyldin601 commented Jun 9, 2024

Maybe use libvpx instead (or as a fallback?) 🤔
This has primarily been developed and optimized for x86-64 architectures.
Maybe there is a little sense in using this codec on arm64 systems?

@wader
Copy link
Owner Author

wader commented Jun 10, 2024

@pyldin601 hey! yeap, after some digging in #301 i came to the same conclusion and maybe understabably intel do not seem to care about arm or generic c for libsvtp9 :) let's close this one.

@wader wader closed this Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants