Fixed code smell

w3stling · Aug 17, 2024 · 2be1e1d · 2be1e1d
1 parent 316a1b3
commit 2be1e1d
Showing 1 changed file with 4 additions and 5 deletions.
diff --git a/src/test/java/com/apptasticsoftware/insynsregistret/TransactionQueryTest.java b/src/test/java/com/apptasticsoftware/insynsregistret/TransactionQueryTest.java
@@ -142,7 +142,7 @@ void validateTransaction() throws IOException {
         assertTrue(transaction.isInitialNotification());
         assertFalse(transaction.isLinkedToShareOptionProgramme());
         assertEquals("Förvärv", transaction.getNatureOfTransaction());
-        //assertEquals("Empir Group AB", transaction.getInstrumentName());
+        assertEquals("Empir Group AB", transaction.getInstrumentName());
         assertEquals("SE0010769182", transaction.getIsin());
         assertEquals(28227, transaction.getQuantity(), 0.0);
         assertEquals("Antal", transaction.getUnit());
@@ -184,7 +184,7 @@ void badPricePointInsteadOfComma() throws IOException {
         assertTrue(transaction.isInitialNotification());
         assertFalse(transaction.isLinkedToShareOptionProgramme());
         assertEquals("Förvärv", transaction.getNatureOfTransaction());
-        //assertEquals("Empir Group AB", transaction.getInstrumentName());
+        assertEquals("Empir Group AB", transaction.getInstrumentName());
         assertEquals("SE0010769182", transaction.getIsin());
         assertEquals(28227, transaction.getQuantity(), 0.0);
         assertEquals("Antal", transaction.getUnit());
@@ -435,8 +435,8 @@ void bigSampleTransaction() throws IOException {
         System.setProperty("insynsregistret.parallel", "false");
 
         ClassLoader classLoader = getClass().getClassLoader();
-        BufferedReader reader = TestUtil.getExportedTransactionFile(classLoader, "insynBigSample.csv");
-        long transactionCount = ir.parseTransactionResponse(reader).count();
+        BufferedReader exportedFileReader = TestUtil.getExportedTransactionFile(classLoader, "insynBigSample.csv");
+        long transactionCount = ir.parseTransactionResponse(exportedFileReader).count();
 
         assertEquals(20436, transactionCount);
     }
@@ -469,7 +469,6 @@ void urlEncodingWithAmpersand() throws IOException {
                 .build();
 
         long count = ir.search(query)
-                .map(Transaction::getIssuer)
                 .count();
 
         assertTrue(count > 0);