Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Implement 405 for unhandled non-GET requests. #62

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kristijanburnik
Copy link
Contributor

Respond with a 405 Method not allowed for non-GET requests which don't match a handler.

The assumption is that a client is sending a POST/PUT/DELETE request for a resource which is otherwise available via GET, therefore respond with 405.

If a handler is not found and the GET method was used, we assume the resource does not exist (404).

@jgraham

@hoppipolla-critic-bot
Copy link

Critic review: https://critic.hoppipolla.co.uk/r/5586

This is an external review system which you may optionally use for the code review of your pull request.

In order to help critic track your changes, please do not make in-place history rewrites (e.g. via git rebase -i or git commit --amend) when updating this pull request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants