Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

argument parsing, json schema generator added #8

Merged
merged 10 commits into from
May 29, 2024
Merged

argument parsing, json schema generator added #8

merged 10 commits into from
May 29, 2024

Conversation

mahdanoura
Copy link
Contributor

addresses #3

@mahdanoura mahdanoura marked this pull request as ready for review May 29, 2024 07:30
lu-zero
lu-zero approved these changes May 29, 2024
View reviewed changes
Copy link
Contributor

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably could be a good idea to not keep the generated files in the repo, beside that it is a huge leap in usability, thank you a lot!

@lu-zero
Copy link
Contributor

lu-zero commented May 29, 2024

Probably the CI could be reworked accordingly?

@mahdanoura mahdanoura merged commit 96f6344 into w3c:main May 29, 2024
1 check failed
@mahdanoura mahdanoura deleted the makefile2poetry branch July 9, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lu-zero lu-zero lu-zero approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahdanoura @lu-zero