Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

readme update #35

Merged
merged 7 commits into from
Sep 18, 2024
Merged

readme update #35

merged 7 commits into from
Sep 18, 2024

Conversation

mahdanoura
Copy link
Contributor

No description provided.

@mahdanoura mahdanoura marked this pull request as draft September 16, 2024 20:23
@mahdanoura mahdanoura requested a review from lu-zero September 16, 2024 20:51
@mahdanoura
Copy link
Contributor Author

@lu-zero could you please run the steps in the README and check whether you can run the code as I described it. Thank you.

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
The main.py script supports various options:
See the list of all WOTIS commands:
```bash
wotis --help
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
wotis --help
uv run wotis --help

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest we keep the wotis --help, because the project installs it as a standalone command, making it simpler to use.

README.md Outdated Show resolved Hide resolved
mahdanoura and others added 2 commits September 17, 2024 09:03
Co-authored-by: Luca Barbato <[email protected]>
Co-authored-by: Luca Barbato <[email protected]>
@mahdanoura mahdanoura marked this pull request as ready for review September 17, 2024 07:05
Copy link
Contributor

@egekorkan egekorkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

regarding the discussion on the command to run: I would prefer to not have something installed globally but if that is the current state of the tooling, we should go with this readme.

@lu-zero
Copy link
Contributor

lu-zero commented Sep 17, 2024

We can land this and iterate over :)

@lu-zero
Copy link
Contributor

lu-zero commented Sep 17, 2024

Meanwhile I fixed the CI, linkml does not support python 3.13 yet.

Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add human-facing comma for clarity

README.md Outdated Show resolved Hide resolved
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@mahdanoura mahdanoura merged commit 5d1f200 into main Sep 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants