Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #34

Merged
merged 9 commits into from
Sep 16, 2024
Merged

Refactor code #34

merged 9 commits into from
Sep 16, 2024

Conversation

mahdanoura
Copy link
Contributor

No description provided.

@mahdanoura mahdanoura marked this pull request as draft September 16, 2024 14:22
Copy link
Contributor

@lu-zero lu-zero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice, also I like a lot the name.

@mahdanoura
Copy link
Contributor Author

thank you @lu-zero :-)

@mahdanoura mahdanoura marked this pull request as ready for review September 16, 2024 19:10
@mahdanoura mahdanoura merged commit b5fd323 into main Sep 16, 2024
1 check failed

def process_inlined_slot(slot, context_entry):
"""
Processes slots that are both inlined, multi-valued and have a instantiates fields.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Processes slots that are both inlined, multi-valued and have a instantiates fields.
Processes slots that are both inlined and multi-valued, in addition to having an instantiates field.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants