Testing of TD instance against created LinkML Schema #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teraction affordance added
…g which had a bug
TallTed
suggested changes
Jul 9, 2024
tests/data/1-simple-default/contentMedia-&-contentEncoding-td-valid.jsonld
Outdated
Show resolved
Hide resolved
tests/data/10-response-and-additional-response/additional-responses-td-valid.jsonld
Outdated
Show resolved
Hide resolved
tests/data/7-complex-data-schemas/readOnly-&-writeOnly-td-valid.jsonld
Outdated
Show resolved
Hide resolved
tests/data/8-meta-interactions/readallproperties-td-valid.jsonld
Outdated
Show resolved
Hide resolved
tests/data/8-meta-interactions/top-level-uriVariables-td-valid.jsonld
Outdated
Show resolved
Hide resolved
tests/data/8-meta-interactions/writeallproperties-td-valid.jsonld
Outdated
Show resolved
Hide resolved
|
@TallTed thank you for the review! These examples are taken from https://github.com/eclipse-thingweb/playground/tree/master/examples/td and your feedback will be mirrored back there as well. Also we have a meeting to talk about this new tooling every Wednesday 15:30 CEST. If you are interested, let me know :) |
…valid.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…onses-td-valid.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
….jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…d.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…-td-valid.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…d.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
…d.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…id.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…sonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
…d.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
…d.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
…sonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
….jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
…-valid.jsonld Co-authored-by: Ted Thibodeau Jr <[email protected]>
Thanks alot @TallTed for all the suggested changes. All the changes have now been applied. |
I usually have a conflict with Weds 09:30 ET (I'm in Massachusetts, USA), but no worries. My primary coding language is English, and my suggestions aren't usually time-sensitive, so I'm fine with doing occasional asynchronous reviews like I did here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds TD instances for testing the created LinkML Schema. The instances have been taken from TD Playground. Some improvements on the LinkML schema is also provided based on the example instances.