Added text about which specification is authoritative. #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vr000m
requested changes
Oct 11, 2016
| @@ -88,29 +88,55 @@ | |||
| [[!WEBRTC]]. | |||
| </p> | |||
| </section><!-- VS: getStats() remains in base spec! --> | |||
| <section class="informative"> | |||
| <h2>Basic concepts</h2> | |||
| <p>The stats API is defined in [[!GETUSERMEDIA]]. It is defined to return | |||
There was a problem hiding this comment.
Wrong reference? Shouldn't this be [[!webrtc]]
| <p>The <code>RTCStatsType</code> member indicates the type of the | ||
| object that the | ||
| <code>RTCStats</code> object represents. An object with a given "type" | ||
| can be only one type of dictionary, but multiple "type" values may use |
There was a problem hiding this comment.
missing: use
can be only /use/ one type of dictionary
There was a problem hiding this comment.
I think it's grammatically correct as it stands, but hard to read. Reformulating.
|
@vr000m please take another look |
vr000m
approved these changes
Oct 12, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5
Partially addresses #55