Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make RTCEncodedVideoFrame and RTCEncodedAudioFrame transferable #238

Closed
wants to merge 3 commits into from

Conversation

jan-ivar
Copy link
Member

@jan-ivar jan-ivar commented Feb 3, 2025

Fixes #231.


Preview | Diff

@jan-ivar jan-ivar self-assigned this Feb 3, 2025
@youennf
Copy link
Collaborator

youennf commented Feb 6, 2025

I am fine with the approach, changing WebIDL is also fine.
We might need to check how to handle the [[data]] slot: after being transferred, it is still exposed in JS and should be a neutered array buffer.

Looking at https://html.spec.whatwg.org/multipage/structured-data.html#structuredserializewithtransfer, we might not need to unset the [[data]] slot, since it might have been detached already by structuredserializewithtransfer.

@jan-ivar
Copy link
Member Author

jan-ivar commented Feb 7, 2025

Abandoned. See #231 (comment).

@jan-ivar jan-ivar closed this Feb 7, 2025
@jan-ivar jan-ivar deleted the transferencodedframes branch February 7, 2025 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No transfer steps defined for RTCEncodedAudioFrame and RTCEncodedVideoFrame
2 participants