Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add receiveTime field to RTCEncodedVideoFrameMetadata and RTCEncodedAudioFrame #237

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add receiveTime field to RTCEncodedVideoFrameMetadata and RTCEncodedAudioFrame #237

wants to merge 1 commit into from

Conversation

guidou
Copy link
Collaborator

@guidou guidou commented Feb 3, 2025 •
edited by pr-preview bot
Loading

Drive-by: Fix bugs preventing proper translation of the spec.

Preview | Diff

Add receiveTime field to RTCEncodedVideoFrameMetadata and RTCEncodedA…
77f9946 
…udioFrameMetadata

Drive-by: Fix bugs preventing proper translation of the spec.
@guidou guidou requested review from aboba, youennf and jan-ivar February 3, 2025 09:47
youennf
youennf approved these changes Feb 6, 2025
View reviewed changes
Copy link
Collaborator

@youennf youennf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make it clear that it only exists for incoming frames, like for other fields.

@guidou guidou mentioned this pull request Feb 7, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@youennf youennf youennf approved these changes

@aboba aboba Awaiting requested review from aboba

@jan-ivar jan-ivar Awaiting requested review from jan-ivar

Assignees
No one assigned
Labels
Editors can integrate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guidou @youennf