Add userName and userDisplayName to webdriver #2148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR adds the userName and userDisplayName properties to the webdriver's credential parameters. These properties are useful to test the new signalCurrentUserDetails method, both on WPTs and for web developers. Closes w3c#2143
nicksteele
approved these changes
Sep 18, 2024
|
Nina to fix the empty name / display name problem |
MasterKale
requested changes
Sep 24, 2024
| <td>|userName|</td> | ||
| <td> | ||
| The {{PublicKeyCredentialUserEntity|user}}'s {{PublicKeyCredentialEntity/name}} associated to the credential. | ||
| If unset, the value will default to the empty string. |
There was a problem hiding this comment.
Hmm, thinking about ways in which PublicKeyCredentialUserEntity.name can be set, user.name is a required value when calling .create(), and signalCurrentUserDetails() requires name be set as well. It feels like a potential foot gun to allow user.name to end up as an empty string when using the virtual authenticator API 🤔
pascoej
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the userName and userDisplayName properties to the webdriver's credential parameters. These properties are useful to test the new signalCurrentUserDetails method, both on WPTs and for web developers.
Closes #2143
The following tasks have been completed:
-- This will be done as a follow-up
Implementation commitment:
Preview | Diff