Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace AuthenticationExtensionsAuthenticatorInputs with CDDL #1440

Merged
merged 5 commits into from
Jul 1, 2020

Conversation

emlun
Copy link
Member

@emlun emlun commented Jun 11, 2020

This replaces the unused WebIDL type AuthenticationExtensionsAuthenticatorInputs with formally defined CDDL extensions point for authenticator extension in/outputs. It doesn't precisely encode that entry keys must be extension identifiers, but the client counterparts also don't, and the prose definition does state this requirement and illustrate it with an example.

Fixes #1435.


Preview | Diff

Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thx @emlun, one modest suggestion...

index.bs Outdated Show resolved Hide resolved
@equalsJeffH
Copy link
Contributor

on 2020-06-17 call: @selfissued will review this week.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm OK with the change to CDDL but I think it would be more helpful to people comparing level 1 and level 2 to leave the type names the same. Therefore please change extensionInputs back to AuthenticationExtensionsAuthenticatorInputs and change extensionOutputs back to AuthenticationExtensionsClientOutputs.

After that change, I'll approve the PR.

@emlun
Copy link
Member Author

emlun commented Jun 25, 2020

Thanks @selfissued - I've renamed the extensionInputs type to AuthenticationExtensionsAuthenticatorInputs, and extensionOutputs to ...AuthenticatorOutputs rather than AuthenticationExtensionsClientOutputs since the latter still remains as a different WebIDL type. The group sockets are still named $$extensionInput and $$extensionOutput, though - would you like me to rename them to AuthenticationExtensionsAuthenticatorInput and ...Output (singular) also?

I also took the opportunity to add some more cross-references and explicitly spell out to use the extension ID as the entry key for the group plugs.

@equalsJeffH equalsJeffH self-requested a review June 29, 2020 18:44
Copy link
Contributor

@equalsJeffH equalsJeffH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks even better to me :)

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now - thanks

@selfissued selfissued merged commit f230f33 into master Jul 1, 2020
WebAuthnBot pushed a commit that referenced this pull request Jul 1, 2020
WebAuthnBot pushed a commit that referenced this pull request Jul 1, 2020
@emlun emlun deleted the issue-1435-extension-io-types branch June 22, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is AuthenticationExtensionsAuthenticatorInputs unused?
3 participants