Support per-hash options and remove MIME type support #236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| It should be noted that this syntax does not allow for [content negotiation][] if | ||
| the developer specifies a MIME type. A change to the syntax to allow this may be | ||
| considered in a future version of the spec, but for now, if a developer wants to | ||
| use content negotiation, they will have to omit an `option-expression`. |
There was a problem hiding this comment.
I would suggest being more explicit here and saying something like:
omit including a type option-expression.
…and to get rid of MIME type note.
…ed in the future.
joelweinberger
changed the title
|
LGTM |
devd
added a commit
that referenced
this pull request
Apr 8, 2015
Support per-hash options and remove MIME type support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reworks grammar to support per-hash options. It also removes the mention of MIME types other than to mention possible support in the future. All of this is as discussed in #235.