Add top-level index.html for dev only (not GH Pages / W3C site) #4076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
kfranqueiro marked as non substantive for IPR from ash-nazg. |
✅ Deploy Preview for wcag2 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
iadawn
approved these changes
Sep 20, 2024
kfranqueiro
added a commit
that referenced
this pull request
Sep 20, 2024
kfranqueiro
added a commit
that referenced
this pull request
Oct 3, 2024
This is a re-do of #4076, with one change: it only pre-clears the output folder (`_site`) for W3C site builds, not for GitHub Pages builds. The deploy script for the latter depends on the output folder _not_ being cleared, in order to layer the new build on top of existing contents. (Fortunately this failed loudly the first time upon deploy, so it didn't affect the contents of the gh-pages branch.) I tested using my own fork this time to make sure the GitHub Pages build would complete, and confirmed that the top-level index.html added in this PR does _not_ output for that build, leaving the existing top-level index.html in the gh-pages branch intact.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Eleventy build and dev server populates subdirectories, but does not create a top-level index.html, which leads to a 404 when you follow the link output to the console by the dev server, or output in PR comments by Netlify. This has already caused confusion for a number of folks.
I initially avoided adding a top-level index page to avoid complications with regard to publishing to GitHub Pages and the W3C Site, but since it's come up a few times and been specifically requested I discussed it with Kevin yesterday and spent some time today working on solving it while keeping it clear of the deployment/publication cases.
Changes
index.html.eleventyignoreto allow for top-level HTML files, while still ignoring top-level files that shouldn't be builtCustomLiquid.tsto avoid processing pages outside oftechniquesorunderstandingindex.html