Fix Video Player problem with keyboard shortcuts #78
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Standard keyboard shortcuts are not working wai-video-standards-and-benefits#127
Source:
if (audiodescribed)
was always true because an array in Liquid is always truthy even when empty (see https://shopify.github.io/liquid/basics/truthy-and-falsy/). Replaced byif (audiodescribed.length > 0)
Resolves flaky behaviour when clicking on the "Audio description button"
Solution: add
data-status
attribute to the<button>
element and not to one of its inner elements.Simplify the code overall (remove unused code, etc.)