Skip to content

Update transformPattern.js to support "patterns/landmarks" getting built #382

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Jan 21, 2025

Copy link

netlify bot commented Jan 21, 2025

Deploy Preview for aria-practices ready!

Name Link
🔨 Latest commit dab4605
🔍 Latest deploy log https://app.netlify.com/sites/aria-practices/deploys/67901b2e266fdc000721aeb9
😎 Deploy Preview https://deploy-preview-382--aria-practices.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@howard-e howard-e requested review from stalgiag and jongund and removed request for stalgiag January 21, 2025 22:13
Copy link
Contributor

@stalgiag stalgiag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to relax this requirement for landmarks pages. Thanks Howard!

@howard-e howard-e merged commit 821e464 into main Jan 22, 2025
4 checks passed
@remibetin remibetin deleted the support-landmarks branch February 14, 2025 13:56
remibetin added a commit that referenced this pull request Mar 19, 2025
* Update `APG` to `WAI` pipeline workflows to handle desync issues and better reports on errors (#361)

* Fix #219
* Update 'deploy.yml' to use 'w3cgruntbot' as committer
* Update 'pr-create.yml' to force a rebase to happen with main in the case generated branch doesn't have relevant changes; additional error handling coverage with 'create-pr' script
* For consistency, rename 'create-pr' script to 'pr-create'
* Remove unnecessary delete branch action

* Infrastructure: Add case to specially handle conflicts in submodule folder to `pr-create.yml` (#373)

* Add case to specially handle conflicts in submodule folder

* Additional pr-create.yml workflow changes to support submodule conflict resolution (#374)

* Infrastructure: Disable git editor during `git rebase --continue` in `pr-create.yml` (#375)

* Update transformPattern.js to support "patterns/landmarks" (#382)

* Pin ruby 3.3.3 instead of 3.3.x during workflow builds (#384)

* chore: Update `main` with latest changes from `aria-practices`

* Remove use of ytkey (deprecated) (#370)

* Infrastructure: Create `.tracked-html-assets.json`  (#388)

* Create .tracked-html-assets.json to make it easier to account for html assets which don't match with the expected html assets' naming structure

* chore: Update `main` with latest changes from `aria-practices`

* chore: Update `main` with latest changes from `aria-practices`

* chore: Update `main` with latest changes from `aria-practices`

* Update .tracked-html-assets.json (#395)

---------

Co-authored-by: w3cgruntbot <[email protected]>
Co-authored-by: Rémi Bétin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants