Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use URI for refreshService id #123

Open
wants to merge 3 commits into
base: gh-pages
Choose a base branch
from
Open

Use URI for refreshService id #123

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
36e4c82
Use URI for refreshService id
clehner Sep 14, 2021
f209ecd
Merge branch 'gh-pages' into cel/refresh-service-id-uri
clehner Feb 3, 2022
e411982
Deprecate URL test
clehner Feb 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions test/vc-data-model-1.0/21-refresh.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,9 +54,8 @@ describe('Refresh Service (optional)', function() {
}
});

it('value of `id` MUST be a URL identifying a service endpoint', async function() {
// test that the `id`'s value is a valid URL
// (possibly) attempt to dereference the service endpoint to validate it's "locator-ness" (i.e. URL vs. URI)
it('value of `id` MUST be a URI identifying a service endpoint', async function() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... while this now requires that id be a URI

// test that the `id`'s value is a valid URI
const doc = await util.generate('example-011.jsonld', generatorOptions);
const services = [].concat(doc.refreshService);

Expand Down