Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First item of VC context is a URL with the value https://www.w3.org/ns/credentials/v2 #1586

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

absoludity
Copy link

@absoludity absoludity commented Jan 20, 2025

While working on a downstream use-case, I noticed that the existing schema checks only that the context contains "https://www.w3.org/ns/credentials/v2", while the v2 spec explicitly says the following regarding context:

The value of the @context property MUST be an ordered set where the first item is a URL with the value https://www.w3.org/ns/credentials/v2.

With that in mind, I think the use of prefixItems to ensure that the first item is the expected URL is more accurate.

While there, I also noted that:

An ordered set is a list with the additional semantic that it must not contain the same item twice.

hence the "uniqueItems" addition.

Tests still pass with those changes (I was unsure if I should add examples that should fail and update the tests to ensure they fail? Let me know), although I do get the warning:

strict mode: "prefixItems" is 1-tuple, but minItems or maxItems/items are not specified or different at path "#/properties/%40context"

which appears to be a known ajv issue.

I was also keen to address the last part of the spec for context:

Subsequent items in the ordered set MUST be composed of any combination of URLs and objects,

but will do that in another PR if it's wanted.

Finally, where do I sign or agree to the w3c patent policy? (apparently the company I'm working for - gosource.com.au - isn't an affiliate member, but I've created an account at https://www.w3.org/account/request/ and listed gosource as my organisation link, which it allowed, and now linked my GH account)

Thanks

@iherman
Copy link
Member

iherman commented Jan 20, 2025

Finally, where do I sign or agree to the w3c patent policy? (apparently the company I'm working for - gosource.com.au - isn't an affiliate member)

I do not think this PR is "substantial", meaning that it proposes a change to handle a bug, and not to add a feature with potential patent concerns. I will validate this PR.

@w3cbot
Copy link

w3cbot commented Jan 20, 2025

iherman marked as non substantive for IPR from ash-nazg.

@absoludity
Copy link
Author

absoludity commented Jan 20, 2025

I do not think this PR is "substantial", meaning that it proposes a change to handle a bug, and not to add a feature with potential patent concerns. I will validate this PR.

Thanks. FWIW, I've created a W3C account and linked my GH profile... not sure if that equates to agreeing to the patent policy, but am happy to do so either way.

@iherman
Copy link
Member

iherman commented Jan 20, 2025

Thanks. FWIW, I've created a W3C account and linked my GH profile... not sure if that equates to agreeing to the patent policy, but am happy to do so either way.

There would be some additional admin steps to take, but these are now unnecessary. Next time, maybe :-)

@msporny msporny added editorial Purely editorial changes to the specification. CR2 labels Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CR2 editorial Purely editorial changes to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants