-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update RDF-semantics with the liberal baseline RDF and RDFS semantics #74
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Editorial. Small language fixes.
There are several markup problems that generate Echidna errors:
Likely, there's some missing closing tag that causes the parser to blow up. It's worth validating the HTML before pushing. |
Thanks. I did it, and I have committed now an error-free html. |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good enough aside from the changes I mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
generally LGTM
Co-authored-by: Pierre-Antoine Champin <[email protected]>
Co-authored-by: Niklas Lindström <[email protected]>
@pfps: I think I resolved all your reviews, but you still appear in the final summary as having a requested change. I don't understand why. |
It's a github thing. I have to sign off somehow. Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now
@doerthe: can you please check whether you like how rdfs14 is written? Maybe propose a better way? Or maybe could be fine if we add an example later? |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Not entirely happy (but almost). I am currently trying to make a proposal. Only obstacle is git, but I am getting there... ;) |
Given the number of commits in this PR, it should be merged using "Squash and merge". |
…ences and completeness proof
Done: |
Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the minor comment, I am happy with the changes.
Update RDF-semantics with the liberal baseline RDF and RDFS semantics
Summary of changes:
Open issue:
TODO
Preview | Diff