Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update RDF-semantics with the liberal baseline RDF and RDFS semantics #74

Merged
merged 24 commits into from
Feb 4, 2025

Conversation

franconi
Copy link
Contributor

@franconi franconi commented Jan 27, 2025

Update RDF-semantics with the liberal baseline RDF and RDFS semantics

Summary of changes:

  • fixed definition of instance in Section 4
  • definition of "appears in" in Section 4
  • added rdf:reifies in RDF vocabulary (Section 8)
  • modified entailment pattern rdfD2 (Section 8.1.1)
  • added rdfs:Proposition in RDFS vocabulary (Section 9)
  • added RDFS semantic condition for rdfs:Proposition (Section 9)
  • added axiomatic triple about range of rdf:reifies (Section 9)
  • modified entailment pattern rdfs4 (Section 9.2.1)
  • addded entailment pattern rdfs14 (Section 9.2.1)
  • added example of incomplete rdfs:Proposition entailment (Appendix A)
  • added complete entailment pattern Grdfs14 for generalised RDF (Appendix A)

Open issue:

  • suggest a better way to write entailment pattern rdfs14 (Section 9.2.1)

TODO

  • check Section 6: Skolemisation
  • check Appendix C: Reification
  • check whole text for consistency

Preview | Diff

@franconi franconi self-assigned this Jan 27, 2025
@franconi franconi added the spec:substantive Change in the spec affecting its normative content (class 3) –see also spec:bug, spec:new-feature label Jan 27, 2025
Copy link
Member

@TallTed TallTed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial. Small language fixes.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@gkellogg
Copy link
Member

There are several markup problems that generate Echidna errors:

  • Error: ROR] Couldn't find ":" in this document or other cited documents: [horst04], [horst05], [owl2-profiles], and [rdf12-concepts].
  • Error: ROR] Couldn't find "****" in this document or other cited documents: [horst04], [horst05], [owl2-profiles], and [rdf12-concepts].
  • Error: ROR] Couldn't find "****" in this document or other cited documents: [rdf12-concepts].
  • Error: ROR] Couldn't find "Finite interpretations To keep the exposition simple, the RDF semantics has been phrased in a way which requires interpretations to be larger than absolutely necessary. For example, all interpretations are required to interpret the whole IRI vocabulary, and the universes of all D-interpretations where D contains xsd:string must contain all possible strings and therefore be infinite. This appendix sketches, without proof, how to re-state the semantics using smaller semantic structures without changing any entailments." in this document or other cited documents: [rdf12-concepts].
  • Error: ROR] Couldn't find "Basically, it is only necessary for an interpretation structure to interpret the" in this document or other cited documents: [rdf12-concepts].
  • Error: ROR] Error in handler for topic "toc": Cannot read properties of null (reading 'textContent')

Likely, there's some missing closing tag that causes the parser to blow up. It's worth validating the HTML before pushing.

@franconi
Copy link
Contributor Author

It's worth validating the HTML before pushing.

Thanks. I did it, and I have committed now an error-free html.

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good enough aside from the changes I mentioned.

spec/index.html Show resolved Hide resolved
Copy link
Contributor

@pchampin pchampin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generally LGTM

spec/index.html Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
spec/index.html Show resolved Hide resolved
@franconi
Copy link
Contributor Author

@pfps: I think I resolved all your reviews, but you still appear in the final summary as having a requested change. I don't understand why.

@pfps
Copy link
Contributor

pfps commented Jan 29, 2025

It's a github thing. I have to sign off somehow.

Done.

Copy link
Contributor

@pfps pfps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

@franconi
Copy link
Contributor Author

@doerthe: can you please check whether you like how rdfs14 is written? Maybe propose a better way? Or maybe could be fine if we add an example later?

spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
spec/index.html Outdated Show resolved Hide resolved
@doerthe
Copy link
Contributor

doerthe commented Jan 31, 2025

@doerthe: can you please check whether you like how rdfs14 is written? Maybe propose a better way? Or maybe could be fine if we add an example later?

Not entirely happy (but almost). I am currently trying to make a proposal. Only obstacle is git, but I am getting there... ;)

@pfps
Copy link
Contributor

pfps commented Jan 31, 2025

Given the number of commits in this PR, it should be merged using "Squash and merge".

@franconi
Copy link
Contributor Author

Done:
(a) wording of rfds14,
(b) deleting offending external references,
(c) refer to an issue on completeness of entailment pattern for rdfs:Proposition.
Waiting for @doerthe to finalise:
(d) typos fixed by doerthe.

spec/index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@doerthe doerthe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comment, I am happy with the changes.

spec/index.html Show resolved Hide resolved
@franconi franconi merged commit bda33c0 into w3c:main Feb 4, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec:substantive Change in the spec affecting its normative content (class 3) –see also spec:bug, spec:new-feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants