Skip to content

Suggestions from January review on Abstract #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 1, 2025
Merged

Suggestions from January review on Abstract #190

merged 7 commits into from
May 1, 2025

Conversation

pchampin
Copy link
Contributor

@pchampin pchampin commented Apr 23, 2025 •
edited by pr-preview bot
Loading

pchampin added 5 commits April 24, 2025 01:23
@pchampin
fix punctuation
964859f 
Bob DuCharme's 6th comment
https://www.w3.org/mid/[email protected]

Bob points out that what looks like an enumeration of 3 things
is actually an enumeration of 2 things.
(this is actually closer to the original phrasing in RDF 1.1 Concepts,
which was "fixed" probably because of an ugly repetition of "and".
I avoided the repetition by using "then")
@pchampin
triple terms should be in the list of terms
23ba4ab
@pchampin
fix grammar...
4675ab4 
... and get rid of controversial "is comprised of"
https://forum.wordreference.com/threads/comprise-vs-is-comprised-of.2654050/
@pchampin
in the web -> on the web
b142c4c 
suggested by @rat10
https://lists.w3.org/Archives/Public/public-rdf-star-wg/2025Jan/0107.html
@pchampin
clarify scope of paragraphs in abstract
116a088
@pchampin pchampin added spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) labels Apr 23, 2025
@pchampin pchampin requested review from hartig, gkellogg and afs April 23, 2025 23:27
hartig
hartig approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@hartig hartig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor fixes.

pchampin and others added 2 commits April 24, 2025 16:41
@pchampin @hartig
Update spec/index.html
dfbb08e 
Co-authored-by: Olaf Hartig <[email protected]>
@pchampin @TallTed
Update spec/index.html
83b53be 
Co-authored-by: Ted Thibodeau Jr <[email protected]>
@afs afs merged commit 0b0a91d into main May 1, 2025
2 checks passed
@afs afs deleted the 2025-01-reviews-abstract branch May 1, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TallTed TallTed TallTed left review comments

@gkellogg gkellogg gkellogg approved these changes

@afs afs afs approved these changes

@hartig hartig hartig approved these changes

Assignees
No one assigned
Labels
spec:editorial Minor change in the specification (markup, typo, informative text; class 1 or 2) spec:enhancement Change to enhance the spec without affecting conformance (class 2) –see also spec:editorial
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@pchampin @gkellogg @afs @hartig @TallTed