Split audio and video configuration. #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It occurs to me that the validation steps for these objects need to be updated since |
|
After discussion at TPAC, there's no clear motivation for landing this. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #146 by splitting
AudioConfigurationintoAudioDecodingConfigurationandAudioEncodingConfiguration, andVideoConfigurationintoVideoDecodingConfigurationandVideoEncodingConfiguration.Decoding-specific properties are moved into the decoding dictionaries.
Caveat: none of these objects have constructors, so this should be backwards compatible, but I have not analyzed this completely for backwards compatibility.
Preview | Diff