-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixup MIME usage #222
base: main
Are you sure you want to change the base?
Fixup MIME usage #222
Conversation
305ab3d
to
b7f3138
Compare
This PR replaces valid media MIME type with algorithmic steps. It could lead to similar changes to valid video configuration all the way up to valid MediaConfiguration. Please comment if you see any issues with the direction this is taking. @aboba One specific question, as we develop this PR: section 2.1.4.2 RTP currently references RFC4855 and RFC6838, which define registration requirements. This PR proposes changing these to reference https://www.iana.org/assignments/rtp-parameters/rtp-parameters.xhtml instead. Is this OK? |
This is ready for review. PTAL @mfoltzgoogle, @aboba, @alastor0325, @marcoscaceres The PR makes two main changes:
If needed we can tackle "valid video configuration" etc in follow-up PRs. |
LGTM with one side comment, nice PR @marcoscaceres I just did a first read of the spec and wondered if a long term possibility is to decouple from mime types along the lines of the WebCodecs registry. However, the registry is missing a bunch of codecs though that may never be supported in WebCodecs, and container parsing support seems to be out of scope for WebCodecs as well. |
There's a similar discussion in this EME issue: w3c/encrypted-media#559. I think a registry could help, but also recognise Joey's concerns in w3c/encrypted-media#559 (comment). This might be one to talk about at TPAC. |
@adoba, bumping the question above in #222 (comment):
|
@chrisn per https://www.w3.org/2024/09/26-mediawg-minutes.html#a01:
After that is done, this should be ready to merge. |
I've added the link to the IANA media type registry, as well as bringing back the references to the RTP specific RFCs. |
@markafoltz I have removed the RFC4855 reference as we discussed in today's meeting (minutes). The PR is ready for your review. Many thanks. |
Co-authored-by: Mark Foltz <[email protected]>
This adds an internal slot to |AudioConfiguration| and |VideoConfiguration| to store the parsed MIME type
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, with a couple of spots I noted where steps could be simplified or the order changed to be more logical. Nothing that blocks merging IMO.
This is ready for another round of review @marcoscaceres Summary of major changes:
I believe this reflects current browser behavior, except for one specific issue around |
Closes #69
this is a draft... it doesn't actually address all the issues with MIME usage yet... just a start.
Preview | Diff