-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define MediaCapabilitiesDecodingInfo.codecSwitchingSupported #165
Open
chcunningham
wants to merge
5
commits into
main
Choose a base branch
from
transition_api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
3102bac
Define MediaCapabilitiesDecodingInfo.codecSwitchingSupported
chcunningham 28b8ac6
Minor dfn re-wording
chcunningham c88c9f8
Xhwang Feedback
chcunningham 1433459
Fixed typos
chrisn 31b912e
Updated references to definitions in MSE spec
chrisn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
|
@@ -22,7 +22,7 @@ Abstract: based on the device's display. | |||||
</pre> | ||||||
|
||||||
<pre class='anchors'> | ||||||
spec: media-source; urlPrefix: https://www.w3.org/TR/media-source/ | ||||||
spec: media-source-2; urlPrefix: https://www.w3.org/TR/media-source-2/ | ||||||
type: interface | ||||||
for: MediaSource; text: MediaSource; url: #mediasource | ||||||
type: method | ||||||
|
@@ -94,6 +94,8 @@ spec: encrypted-media; for: EME; urlPrefix: https://www.w3.org/TR/encrypted-medi | |||||
text: MediaKeysRequirement; url: dom-mediakeysrequirement | ||||||
text: audioCapabilities; url: dom-mediakeysystemconfiguration-audiocapabilities | ||||||
text: contentType; url: dom-mediakeysystemmediacapability-contenttype | ||||||
type: method | ||||||
text: setMediaKeys(); url: dom-htmlmediaelement-setmediakeys | ||||||
|
||||||
spec: encrypted-media-draft; for: EME; urlPrefix: https://w3c.github.io/encrypted-media/# | ||||||
type: attribute | ||||||
|
@@ -180,6 +182,22 @@ spec: secure-contexts; urlPrefix: https://www.w3.org/TR/secure-contexts/ | |||||
</p> | ||||||
</section> | ||||||
|
||||||
<section> | ||||||
<h2 id='definitions'>Definitions</h2> | ||||||
<dl> | ||||||
<dt><dfn>Decoding Pipeline</dfn></dt> | ||||||
<dd> | ||||||
A configuration of internal user agent components that implement media | ||||||
decoding. For the purposes of this specification, we conceive of user | ||||||
agents having distinct pipelines for encrypted vs unencrypted media. | ||||||
Additionally, user agents may support several distinct encrypted media | ||||||
pipelines, which must be signalled by using different | ||||||
{{MediaCapabilitiesKeySystemConfiguration/keySystem}} names or different | ||||||
{{KeySystemTrackConfiguration/robustness}} levels. | ||||||
</dd> | ||||||
</dl> | ||||||
</section> | ||||||
|
||||||
<section> | ||||||
<h2 id='decoding-encoding-capabilities'>Decoding and Encoding Capabilities</h2> | ||||||
|
||||||
|
@@ -766,6 +784,7 @@ spec: secure-contexts; urlPrefix: https://www.w3.org/TR/secure-contexts/ | |||||
|
||||||
<pre class='idl'> | ||||||
dictionary MediaCapabilitiesDecodingInfo : MediaCapabilitiesInfo { | ||||||
required boolean codecSwitchingSupported; | ||||||
required MediaKeySystemAccess keySystemAccess; | ||||||
MediaDecodingConfiguration configuration; | ||||||
}; | ||||||
|
@@ -794,6 +813,21 @@ spec: secure-contexts; urlPrefix: https://www.w3.org/TR/secure-contexts/ | |||||
temperature or the fans noise. | ||||||
</p> | ||||||
|
||||||
<p> | ||||||
A {{MediaCapabilitiesDecodingInfo}} has an associated | ||||||
<dfn dict-member for='MediaCapabilitiesDecodingInfo'> | ||||||
codecSwitchingSupported</dfn> which is a boolean. | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
</p> | ||||||
|
||||||
<p class='note'> | ||||||
Authors can use {{MediaCapabilitiesDecodingInfo/codecSwitchingSupported}} | ||||||
to determine whether the user agent supports codec switching via | ||||||
{{SourceBuffer/changeType()}} within the described | ||||||
<a>decoding pipeline</a>. Note that switching between | ||||||
<a>decoding pipelines</a> is a separate quality of implementation issue | ||||||
as described by {{EME/setMediaKeys()}}. | ||||||
</p> | ||||||
|
||||||
<p> | ||||||
A {{MediaCapabilitiesDecodingInfo}} has associated | ||||||
<dfn dict-member for=MediaCapabilitiesDecodingInfo>keySystemAccess</dfn> | ||||||
|
@@ -940,6 +974,23 @@ spec: secure-contexts; urlPrefix: https://www.w3.org/TR/secure-contexts/ | |||||
efficiency unless the device's power source has side effects | ||||||
such as enabling different decoding modules. | ||||||
</li> | ||||||
<li> | ||||||
If <code>configuration.type</code> is set to | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can |
||||||
{{MediaDecodingType/media-source}}: | ||||||
<ol> | ||||||
<li> | ||||||
Let <var>pipeline</var> be the <a>decoding pipeline</a> | ||||||
described by <var>configuration</var>. | ||||||
</li> | ||||||
<li> | ||||||
If <var>pipeline</var> is able to support using | ||||||
{{SourceBuffer}} {{SourceBuffer/changeType()}} to switch | ||||||
between any and all of its supported codecs, set | ||||||
{{MediaCapabilitiesDecodingInfo/codecSwitchingSupported}} | ||||||
to <code>true</code>. Otherwise, set it to <code>false</code>. | ||||||
</li> | ||||||
</ol> | ||||||
</li> | ||||||
<li> | ||||||
Return <var>info</var>. | ||||||
</li> | ||||||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You shouldn't need this in theory. Or if we do, we need to figure out why it hasn't been exported from the other spec.