-
Notifications
You must be signed in to change notification settings - Fork 30
#314: Made focusNode an explicit param of exprEval, SPARQL-based expressions now pre-bind all scope vars #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh-pages
Are you sure you want to change the base?
Conversation
Interestingly I was also trying to add links to the githack renderings, but they were (for me) still caching an earlier version, and didn't show the second commit. So I elected not to include the link. But it renders fine now... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tweaks for clarity. I feel strongly that SPARQL keywords (like SELECT
) should be presented within <code>
elements.
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Not sure where to put comment but if this is @HolgerKnublauch's active PR ...
Node expressions return lists.
Is that the right behaviour? Wouldn't it be better to make it the conjunction of the list so any violation is a violation. That stops the case where an accidental mistake adding value when only one is expected can make it pass.
|
I have no strong opinion on sh:expression. I believe in the original draft it had to return exactly [ true ]. However, I have the feeling that when a NE returns multiple values, the general interpretation should be "or". For example, sh:class ( ex:Class1 ex:Class2 ) should be satisfied if either class is present among the types. One approach moving forward is to move this constraint component into the NE document and let it evolve there. So when people have more experience with NEs, we can adjust the semantics accordingly. It doesn't really need to be in Core. |
As in node expression As a property shape, it's "and"-like For Others are not naturally an "or":
What would
be? a list of N*M results?
Maybe nodes expression evaluation should be defined to return "node or list of nodes" and node-expr functions declare which they are. |
Ok, this change to sh:expression is fine for me. Changed to [ true ] on the branch. |
Two changes in this PR:
Closes #314