Skip to content

#276: Unify ex namespace usage in tests #362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: gh-pages
Choose a base branch
from

Conversation

YoucTagh
Copy link
Contributor

@YoucTagh YoucTagh commented Apr 14, 2025

This is a PR to unified the use of ex in tests

  • I changed @prefix ex: <http://... to @prefix ex: <http://example.com/ns#> .
  • I changed
    sh:declare [
          sh:namespace "..."^^xsd:anyURI ;
          sh:prefix "ex" ;
        ] ;
    
    to:
    sh:declare [
          sh:namespace "http://example.com/ns#"^^xsd:anyURI ;
          sh:prefix "ex" ;
        ] ;
    
  • I changed PREFIX ex ... to http://example.com/ns#

Closes #276

@ajnelson-nist
Copy link
Contributor

I noticed a lot of diff noise unrelated to the in-scope changes of this PR. It looks like line endings weren't consistent between files - some were DOS endings, some not.

Dear reviewers: How are we handling line endings repository-wide? Does this PR's initial commit need to be force-pushed to minimize its change to the in-scope effects? I find it unfortunate to lose git blame value from line ending issues.

@YoucTagh
Copy link
Contributor Author

I believe it is also possible to use .gitattributes, but I haven't used it before.

Copy link
Contributor

@ajnelson-nist ajnelson-nist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Commenting using the Review mechanism - same sentiment as in my initial comment on this PR.)

I would prefer this PR not alter every line of every file due to line ending changes, unless the group agrees to add some mechanism to prevent a future global change from happening accidentally. .gitattributes would be fine if someone could get it working. I've personally been unlucky with that file, so I'll refrain from adding it myself, but won't object to someone else adding it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Namespace of ex: in tests
2 participants