Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify what happens after authentication. #122

Merged
merged 2 commits into from
Nov 23, 2024
Merged

Conversation

msporny
Copy link
Member

@msporny msporny commented Nov 16, 2024

This PR is an attempt to address issue #61 by using @selfissued's language to clarify what happens after authentication.


Preview | Diff

index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@David-Chadwick David-Chadwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is really important to be clear whether the authentication relationship refers to the controller or to the subject, given that they are not always the same entity. I think @dlongley is correct and it should be the subject

@dlongley
Copy link
Contributor

@David-Chadwick,

Yes -- and I had another comment on here that I removed because Joe's PR #116 will also help clarify: #116 (comment) ... and I don't want to create more churn here.

@iherman
Copy link
Member

iherman commented Nov 20, 2024

The issue was discussed in a meeting on 2024-11-20

  • no resolutions were taken
View the transcript

1.4. Clarify what happens after authentication. (pr controller-document#122)

See github pull request controller-document#122.

Brent Zundel: A couple more comments and a few fewer approvals than last one.

Manu Sporny: Another from Mike Jones, he felt like the description wasn't adequate. I have tried to apply some of his language to this to clarify the definition.

Brent Zundel: Please review and if you have comments, we can discuss, otherwise onto the next one.

@msporny
Copy link
Member Author

msporny commented Nov 23, 2024

Editorial, multiple reviews, changes requested and made, no objections, merging.

@msporny msporny merged commit 3da618c into main Nov 23, 2024
1 check passed
@msporny msporny deleted the msporny-clarify-authn branch November 23, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants