Fix handling of CSS specs and CSS snapshots #1158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The W3C API cannot be trusted for CSS specs and CSS snapshots because it mixes the two in the same series, is case-insensitive on the shortname, and may change the case of the returned shortname when a new spec gets published in one of these series. That typically happened with the recent publication of the CSS 2023 snapshot, which broke the build as a result. This update makes the code ignore the info from the W3C API for these series, and rather hardcodes the series titles. The code will also use the latest version as the current specification for each of these series. If we need to override this, we'll have to do it in `specs.json`.
dontcallmedom
approved these changes
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The W3C API cannot be trusted for CSS specs and CSS snapshots because it mixes the two in the same series, is case-insensitive on the shortname, and may change the case of the returned shortname when a new spec gets published in one of these series. That typically happened with the recent publication of the CSS 2023 snapshot, which broke the build as a result.
This update makes the code ignore the info from the W3C API for these series, and rather hardcodes the series titles. The code will also use the latest version as the current specification for each of these series. If we need to override this, we'll have to do it in
specs.json.