Issue#15 - use alternative API design to replace the old methods. #16
Conversation
Use `navigator.getAutoplayPolicy(ctor)` and `navigator.getAutoplayPolicy(object)` to replace the old API design.
| partial interface Navigator { | ||
| AutoplayPolicy getAutoplayPolicy(HTMLMediaElementConstructor ctor); | ||
|
|
||
| AutoplayPolicy getAutoplayPolicy(AudioContextConstructor ctor); |
There was a problem hiding this comment.
One problem I would like to discuss here is, if a web developer passes a contructor which is not HTMLMediaElementConstructor and AudioContextConstructor, should we throw an exception?
Same problem for query-by-a-element case as well, if a web developer passes other elements which we don't support.
…agent to pause media element after element becomes audible.
|
Hello, @chrisguttandin @liberato-at-chromium, just want to confirm with y'all to see if y'all have any suggestion on this new version update? In addition, @chrisn, sorry because I'm still not familiar with the working flow on Media Working Group. I would like to know if there is any convention that how many reviewers I would need for a PR? Thank y'all so much. |
In general, as spec editor, you should feel empowered to merge a PR whenever you feel that it can be merged. This is in line with the decision section in the Media WG charter. Merging a PR does not set things in stone in any case and I think it's totally reasonable to iterate on small increments. Besides, this spec has not yet been published to /TR, so it only exists as an Editor's Draft for now (which essentially means that it's yours ;)) If you'd rather get a more explicit signal from the Media WG, you could put it on the agenda for next week's meeting for instance. |
I agree with @tidoust's comments. You're welcome to merge the PR when you think it's ready. We can get review from Working Group members as a separate step, again, when you're ready. |
sorry for the late reply -- lgtm. |
Based on the discussion in issue#15, use new API design,
navigator.getAutoplayPolicy(ctor)andnavigator.getAutoplayPolicy(object), to replace the old API design.