-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add aria-checked support to gridcell and row #2390
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?
Otherwise, this LGTM! 🚀
Heh, my personal opinion is still that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me!
@mcking65 can you please review |
Closes #1960
Adds
aria-checked
as a supported state togridcell
, with the same wording around combiningaria-checked
&aria-selected
as onoption
andtreeitem
. Thearia-checked
support also inherits intocolumnheader
androwheader
.Test, Documentation and Implementation tracking
Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.
Preview | Diff