Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add aria-checked support to gridcell and row #2390

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

smhigley
Copy link
Contributor

@smhigley smhigley commented Dec 3, 2024

Closes #1960

Adds aria-checked as a supported state to gridcell, with the same wording around combining aria-checked & aria-selected as on option and treeitem. The aria-checked support also inherits into columnheader and rowheader.

Test, Documentation and Implementation tracking

Once this PR has been reviewed and has consensus from the working group, tests should be written and issues should be opened on browsers. Add N/A and check when not applicable.

  • "author MUST" tests: N/A
  • "user agent MUST" tests: N/A
  • Browser implementations (link to issue or commit):
    • WebKit:
    • Gecko:
    • Blink:
  • Does this need AT implementations? Likely not, since this should come from browser mappings
  • Related APG Issue/PR: N/A
  • MDN Issue/PR:

Preview | Diff

Copy link

netlify bot commented Dec 3, 2024

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit ddc6426
🔍 Latest deploy log https://app.netlify.com/sites/wai-aria/deploys/67576e4b00e89600089393b3
😎 Deploy Preview https://deploy-preview-2390--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@adampage adampage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Otherwise, this LGTM! 🚀

@smhigley
Copy link
Contributor Author

smhigley commented Dec 5, 2024

Is there a persuasive and easy-to-describe use case where all of those extremely rare conditions are sufficiently satisfied? 😅 If so, how about offering it in a note?

Heh, my personal opinion is still that aria-checked and aria-selected never belong on the same node together. That debate happened a while ago though, and the current wording (borrowed from option and treeitem) is the result 🤪

@smhigley smhigley changed the title feat: add aria-checked support to gridcell feat: add aria-checked support to gridcell and row Dec 9, 2024
Copy link
Member

@hidde hidde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me!

@jnurthen jnurthen removed the request for review from hidde-logius December 19, 2024 18:23
@jnurthen
Copy link
Member

@mcking65 can you please review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider supporting aria-checked on gridcells
4 participants