[Draft] Enables respec darkmode #2138
Conversation
daniel-montalvo
added
the
editorial
|
This follows w3c/respec#3236 Much appreciated if anyone can please test this to see how it actually works in the ARIA context. |
|
Hi @daniel-montalvo, I’m not sure this is a valid review, but the issue is still present in this PR’s auto-generated diff preview. respec’s diff engine found 4 changes to the ARIA spec in this PR that I presume are unrelated to your commit, but that did create a visual diff which still exhibits the color issue. Is it possible for me to run respec locally and produce a diff preview after making a quick content change to the spec’s index.html file? I’m wondering if the issue might show up as resolved in that context. |
|
@daniel-montalvo this doesn't seem to have any any visual effect when switching my browser's dark/light mode. I also tried manually adding |
|
Oh, as @adampage said, the diffs are (still) affected and still exhibiting the bug that Adam had reported. |
|
The dark mode feature has been merged in respec, but not yet deployed in a release, so it is expected this would not have an effect yet |
Thanks @dontcallmedom for clarifying this, wasn't sure about whether it was already deployed or not. |
|
Moving this to draft until this is actually deployed in a respec release |
daniel-montalvo
changed the title
|
It's released now. |
|
@daniel-montalvo following today's call I checked again. I do not see any changes in the preview when forcing dark mode. Doe the previews need to be refreshed in some way perhaps? |
index.html
Outdated
| @@ -155,6 +155,7 @@ | |||
| xref: ["dom", "accname-1.2", "core-aam-1.2", "infra", "HTML"], | |||
| definitionMap: [] | |||
| }; | |||
| darkMode: true; | |||
There was a problem hiding this comment.
ReSpec removed this config option today (https://github.com/w3c/respec/pull/4700) in favor of the color-scheme meta tag.
https://lists.w3.org/Archives/Public/spec-prod/2024AprJun/0000.html
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
daniel-montalvo
force-pushed
the
enable-darkMode
branch
from
bf93b50 to
2108459
Compare
|
@daniel-montalvo in the latest netlify preview, I still don't see a visual change when forcing darkmode (in Chrome or Firefox). Sorry :( |
|
I see the change in the preview. My OS is set to dark mode and I see this:
If I force light mode in dev tools I see the opposite:
Note that the suggestion about removing |
|
@kfranqueiro thanks for making me take another look. I now noticed that when I switch to darkmode after loading, there's no effect. But if I reload the page, it's switched to dark mode. Maybe that's the expected behavior of respec right now. [Edit: once reloaded in dark mode, switching in and out of dark mode works as expected - I see this on both Chromium and Firefox so I suspect something is not quite right on the respec end.) We need to fix our CSS, e.g., common.css sets table cells to a background of |
|
@daniel-montalvo let me know if you'd like CSS fixes as part of this PR or afterwards. |
|
Thanks @kfranqueiro for taking a look at this. @pkra Happy for the CSS changes to be included in this PR. |
|
Merging as per editors' meeting today. |
SHA: 6b1ba84 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Closes #2133
Enables darkmode compatibilty through respecConfig.darkMode
Preview | Diff