Override the "mode" of Service Worker requests #1534
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tests for this behavior have already been merged to WPT: https://github.com/web-platform-tests/wpt/blob/1740f4c70674b363cce9fddd19eb4110a54d609e/fetch/metadata/serviceworker.https.sub.html Firefox 82 and Chromium 86 both implement this behavior: https://wpt.fyi/results/fetch/metadata/serviceworker.https.sub.html?run_id=645350001&run_id=647020002&run_id=641150001&run_id=657230003
|
@jugglinmike can you make IPR commitments to this group? |
|
Wait, doesn't this prevent cross-origin importScripts? Shouldn't the mode be something else for non-top-level requests? |
|
@wanderview you're right. The discussion of whatwg/html#5875 has more information about why this patch affects more requests than intended. I ought to have closed this when that became apparent--sorry for the distraction! @jakearchibald @wanderview Would you mind confirming that the other patch is how we should address this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests for this behavior have already been merged to WPT:
https://github.com/web-platform-tests/wpt/blob/1740f4c70674b363cce9fddd19eb4110a54d609e/fetch/metadata/serviceworker.https.sub.html
Firefox 82 and Chromium 86 both implement this behavior:
https://wpt.fyi/results/fetch/metadata/serviceworker.https.sub.html?run_id=645350001&run_id=647020002&run_id=641150001&run_id=657230003
We could also specify this by extending an existing step that concerns other workers. In a patch to do that, it was suggested that Service Workers was the more appropriate location.
Preview | Diff