Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add eval test cases for empty graph and isImpliedBy #202

Merged
merged 5 commits into from
Oct 17, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: remove invalid .nq syntax
jeswr committed Oct 15, 2023

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 69b00a07cddfd4fa87d90335808eabf71cc810be
2 changes: 0 additions & 2 deletions tests/N3Tests/graph/empty_graph_implies.nq

This file was deleted.

3 changes: 3 additions & 0 deletions tests/N3Tests/graph/empty_graph_implies_result.n3
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"true"^^<http://www.w3.org/2001/XMLSchema#boolean> <http://www.w3.org/2000/10/swap/log#implies> "true"^^<http://www.w3.org/2001/XMLSchema#boolean>
} <http://www.w3.org/2000/10/swap/log#implies> "true"^^<http://www.w3.org/2001/XMLSchema#boolean> .
1 change: 0 additions & 1 deletion tests/N3Tests/isImpliedBy/isImpliedBy.nq
Original file line number Diff line number Diff line change
@@ -1,2 +1 @@

<http://example.com/a> <http://www.w3.org/2000/10/swap/log#isImpliedBy> <http://example.com/b> .
6 changes: 0 additions & 6 deletions tests/N3Tests/isImpliedBy/isImpliedBy_bcRule.nq

This file was deleted.

9 changes: 9 additions & 0 deletions tests/N3Tests/isImpliedBy/isImpliedBy_bcRule_result.n3
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
{ <http://example.org/s> <http://example.org/p> ?O } <http://www.w3.org/2000/10/swap/log#implies> ?O .

<http://example.org/s> <http://example.org/p> {
{
?a <http://example.org/b1> <http://example.org/c1> .
} <http://www.w3.org/2000/10/swap/log#isImpliedBy> {
?a <http://example.org/b> <http://example.org/c> .
} .
} .
4 changes: 0 additions & 4 deletions tests/N3Tests/isImpliedBy/isImpliedBy_graphs.nq

This file was deleted.

5 changes: 5 additions & 0 deletions tests/N3Tests/isImpliedBy/isImpliedBy_graphs_result.n3
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
<http://example.com/a> <http://example.com/b> <http://example.com/c>
} <http://www.w3.org/2000/10/swap/log#isImpliedBy> {
<http://example.com/d> <http://example.com/e> <http://example.com/f>
} .
6 changes: 3 additions & 3 deletions tests/N3Tests/manifest-parser.ttl
Original file line number Diff line number Diff line change
@@ -1034,7 +1034,7 @@
:empty_graph_implies_eval
a test:TestN3Eval ;
mf:action <graph/empty_graph_implies.n3> ;
mf:result <graph/empty_graph_implies.nq> ;
mf:result <graph/empty_graph_implies_result.n3> ;
mf:name "Empty Graph Implies Eval";
rdfs:comment "Empty Graph should be parsed as the the literal true when in global scope and when in a premise";
rdft:approval rdft:Approved .
@@ -1050,15 +1050,15 @@
:isImpliedBy_graphs
a test:TestN3Eval ;
mf:action <isImpliedBy/isImpliedBy_graphs.n3> ;
mf:result <isImpliedBy/isImpliedBy_graphs.nq> ;
mf:result <isImpliedBy/isImpliedBy_graphs_result.n3> ;
mf:name "isImpliedBy Eval";
rdfs:comment "<= should be parsed as log:isImpliedBy in a complex use case";
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unsure what is meant by complex use case?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure either - resolved in 59f2ae7.

I don't have permissions to merge on this repo so will leave that to you.

jeswr marked this conversation as resolved.
Show resolved Hide resolved
rdft:approval rdft:Approved .

:isImpliedBy_bcRule
a test:TestN3Eval ;
mf:action <isImpliedBy/isImpliedBy_bcRule.n3> ;
mf:result <isImpliedBy/isImpliedBy_bcRule.nq> ;
mf:result <isImpliedBy/isImpliedBy_bcRule_result.n3> ;
mf:name "isImpliedBy Eval";
rdfs:comment "<= should be parsed as log:isImpliedBy in a bcRule";
rdft:approval rdft:Approved .