Specify the fields API #668
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TallTed
suggested changes
Oct 28, 2024
|
Thanks @TallTed, addresssed your comments. |
npm1
reviewed
Oct 29, 2024
npm1
approved these changes
Nov 7, 2024
TallTed
suggested changes
Nov 8, 2024
| @@ -895,8 +895,13 @@ the exception thrown. | |||
| |accountsList|. | |||
| 1. If |account| is failure, return (failure, true). | |||
| 1. If [=compute the connection status=] of |account|, |provider| and |globalObject| is | |||
There was a problem hiding this comment.
Suggested change
| 1. If [=compute the connection status=] of |account|, |provider| and |globalObject| is | |
| 1. If [=compute the connection status=] of |account|, |provider|, and |globalObject| is |
| [=compute the connection status/connected=], set |permission| to true. | ||
| 1. Otherwise, if |provider|.{{IdentityProviderRequestOptions/fields}} is [=list/empty=], | ||
| [=create a connection between the RP and the IdP account=] with |provider|, |account|, | ||
| and |globalObject| and set |permission| to |true|. |
There was a problem hiding this comment.
Suggested change
| and |globalObject| and set |permission| to |true|. | |
| and |globalObject|, and set |permission| to |true|. |
|
|
||
| Note: This parameter exists for backwards compatibility with older identity providers | ||
| that do not yet support `disclosure_shown_for`. At the time, the disclosure text, | ||
| if shown, always included name, email and picture. Newer identity providers should |
There was a problem hiding this comment.
Suggested change
| if shown, always included name, email and picture. Newer identity providers should | |
| if shown, always included name, email, and picture. Newer identity providers should |
| Note: This parameter exists for backwards compatibility with older identity providers | ||
| that do not yet support `disclosure_shown_for`. At the time, the disclosure text, | ||
| if shown, always included name, email and picture. Newer identity providers should | ||
| check `disclosure_shown_for` instead. |
There was a problem hiding this comment.
Suggested change
| check `disclosure_shown_for` instead. | |
| instead check `disclosure_shown_for`. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: w3c-fedid/custom-requests#4
Preview | Diff