Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discussion of xi c14n. #3

Merged
merged 11 commits into from
May 28, 2024

Conversation

wes-smith
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented May 28, 2024

PR Preview Action v1.4.7
🚀 Deployed preview to https://digitalbazaar.github.io/verifiable-barcodes/pr-preview/pr-3/
on branch gh-pages at 2024-05-28 22:13 UTC

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
}</span>,
"credentialSubject": {
"type": <span class="highlight">"Pdf417Barcode"</span>,
<span class="highlight">"type": "UsDriversLicenseWithMandatoryFieldsPdf417Barcode"</span>,
<span class="highlight">"signatureBitfield": "uP_BA"</span>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hindsight, this probably should have been protectedFields or something along those lines. The bitfield doesn't have to do with the signature, it's the fields that are protected by the signature.

index.html Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
Copy link
Contributor

@msporny msporny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits, otherwise LGTM.

@wes-smith wes-smith merged commit d42af53 into main May 28, 2024
1 check passed
@msporny msporny deleted the add-discussion-of-xi-c14n-and-status-list branch May 29, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants