-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed requirements #192
Closed
Closed
Fixed requirements #192
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
6c80192
- added missing requirements and version dependencies
Hg347 d226be3
- added development environment installation notes
Hg347 a197006
Update .gitignore
Hg347 0d5418c
Update README.md
Hg347 4ca4175
Update README.md
Hg347 c0c9f93
Update README.md
Hg347 8cd8387
Cleaned up and reorganized
Hg347 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,3 +16,5 @@ sphinx-rtd-theme | |
# jupyter | ||
jupyter_server | ||
nest_asyncio | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
ipython==8.23.0 | ||
Sphinx==7.2.6 | ||
black==24.3.0 | ||
flake8==7.0.0 | ||
flake8-bugbear==24.2.6 | ||
flake8-use-fstring==1.4 | ||
hypothesis==6.100.1 | ||
isort==5.13.2 | ||
mypy==1.9.0 | ||
pre-commit==3.7.0 | ||
pytest==8.1.1 | ||
pytest-xdist==3.5.0 | ||
pytest-cov==5.0.0 | ||
sphinx-rtd-theme==2.0.0 | ||
|
||
# jupyter | ||
jupyter_server==2.13.0 | ||
nest-asyncio==1.6.0 | ||
## The following requirements were added by pip freeze: | ||
alabaster==0.7.16 | ||
annotated-types==0.6.0 | ||
anyio==4.3.0 | ||
argon2-cffi==23.1.0 | ||
argon2-cffi-bindings==21.2.0 | ||
arrow==1.3.0 | ||
asttokens==2.4.1 | ||
attrs==23.2.0 | ||
Babel==2.14.0 | ||
beautifulsoup4==4.12.3 | ||
bitarray==2.9.2 | ||
bleach==6.1.0 | ||
cached-property==1.5.2 | ||
cbor2==5.6.2 | ||
certifi==2024.2.2 | ||
cffi==1.16.0 | ||
cfgv==3.4.0 | ||
charset-normalizer==3.3.2 | ||
ckzg==1.0.0 | ||
click==8.1.7 | ||
coverage==7.4.4 | ||
cytoolz==0.12.3 | ||
decorator==5.1.1 | ||
defusedxml==0.7.1 | ||
distlib==0.3.8 | ||
docutils==0.20.1 | ||
eth-account==0.12.1 | ||
eth-bloom==3.0.0 | ||
eth-hash==0.7.0 | ||
eth-keyfile==0.8.0 | ||
eth-keys==0.5.0 | ||
eth-rlp==2.1.0 | ||
eth-stdlib==0.2.7 | ||
eth-typing==4.1.0 | ||
eth-utils==4.1.0 | ||
eth_abi==5.1.0 | ||
execnet==2.1.1 | ||
executing==2.0.1 | ||
fastjsonschema==2.19.1 | ||
filelock==3.13.4 | ||
fqdn==1.5.1 | ||
hexbytes==1.2.0 | ||
identify==2.5.35 | ||
idna==3.6 | ||
imagesize==1.4.1 | ||
importlib_metadata==7.1.0 | ||
iniconfig==2.0.0 | ||
isoduration==20.11.0 | ||
jedi==0.19.1 | ||
Jinja2==3.1.3 | ||
jsonpointer==2.4 | ||
jsonschema==4.21.1 | ||
jsonschema-specifications==2023.12.1 | ||
jupyter-events==0.10.0 | ||
jupyter_client==8.6.1 | ||
jupyter_core==5.7.2 | ||
jupyter_server_terminals==0.5.3 | ||
jupyterlab_pygments==0.3.0 | ||
lru-dict==1.3.0 | ||
markdown-it-py==3.0.0 | ||
MarkupSafe==2.1.5 | ||
matplotlib-inline==0.1.6 | ||
mccabe==0.7.0 | ||
mdurl==0.1.2 | ||
mistune==3.0.2 | ||
mypy-extensions==1.0.0 | ||
nbclient==0.10.0 | ||
nbconvert==7.16.3 | ||
nbformat==5.10.4 | ||
nodeenv==1.8.0 | ||
overrides==7.7.0 | ||
packaging==23.2 | ||
pandocfilters==1.5.1 | ||
parsimonious==0.10.0 | ||
parso==0.8.4 | ||
pathspec==0.12.1 | ||
pexpect==4.9.0 | ||
platformdirs==4.2.0 | ||
pluggy==1.4.0 | ||
prometheus_client==0.20.0 | ||
prompt-toolkit==3.0.43 | ||
ptyprocess==0.7.0 | ||
pure-eval==0.2.2 | ||
py-ecc==7.0.0 | ||
py-evm==0.10.0b6 | ||
pycodestyle==2.11.1 | ||
pycparser==2.22 | ||
pycryptodome==3.20.0 | ||
pydantic==2.6.4 | ||
pydantic_core==2.16.3 | ||
pyflakes==3.2.0 | ||
Pygments==2.17.2 | ||
python-dateutil==2.9.0.post0 | ||
python-json-logger==2.0.7 | ||
PyYAML==6.0.1 | ||
pyzmq==25.1.2 | ||
referencing==0.34.0 | ||
regex==2023.12.25 | ||
requests==2.31.0 | ||
rfc3339-validator==0.1.4 | ||
rfc3986-validator==0.1.1 | ||
rich==13.7.1 | ||
rlp==4.0.0 | ||
rpds-py==0.18.0 | ||
Send2Trash==1.8.3 | ||
six==1.16.0 | ||
sniffio==1.3.1 | ||
snowballstemmer==2.2.0 | ||
sortedcontainers==2.4.0 | ||
soupsieve==2.5 | ||
sphinxcontrib-applehelp==1.0.8 | ||
sphinxcontrib-devhelp==1.0.6 | ||
sphinxcontrib-htmlhelp==2.0.5 | ||
sphinxcontrib-jquery==4.1 | ||
sphinxcontrib-jsmath==1.0.1 | ||
sphinxcontrib-qthelp==1.0.7 | ||
sphinxcontrib-serializinghtml==1.1.10 | ||
stack-data==0.6.3 | ||
terminado==0.18.1 | ||
tinycss2==1.2.1 | ||
toolz==0.12.1 | ||
tornado==6.4 | ||
traitlets==5.14.2 | ||
trie==2.1.1 | ||
types-python-dateutil==2.9.0.20240316 | ||
typing_extensions==4.11.0 | ||
uri-template==1.3.0 | ||
urllib3==2.2.1 | ||
virtualenv==20.25.1 | ||
vyper==0.3.10 | ||
wcwidth==0.2.13 | ||
webcolors==1.13 | ||
webencodings==0.5.1 | ||
websocket-client==1.7.0 | ||
zipp==3.18.1 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be deleted, the dependencies are in pyproject.toml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too, I'm new to python. My understanding so far, the .toml file contains the runtime or "production" configuration, while requirements.txt specifies the development setup.
Here is my reasoning
That is, .toml should contain neither pytest nor hypothesis, but requirements.txt should contain both.
Second, as developer I would like to have two things:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
honestly if there is an update to a library that causes an issue, we should want to find out in the development cycle. freezing the requirements like so silences the issue until users find it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, I see your point. Still, I couldn't work or contribute for weeks because the tests failed.
From my perspective, the idea of the master branch in Git is that there is a common, working base. This why I suggested a dev_requirements and a freezed_requirements. This solution would take both views into account.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how were the tests failing? and how did you end up fixing them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
easy to reproduce: few weeks ago I fetched the main branch: commit 98c7b58
Then I did:
The last command is necessary since you published a newer version of titanoboa meanwhile.
Finally I executed
Result: 23 failed, 168 passed, 2 warnings, 71 errors in 19.26s
If I use the requirements.txt as specified in this PR all tests pass.