Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T973: add basic node_exporter implementation #4048

Open
wants to merge 1 commit into
base: current
Choose a base branch
from

Conversation

rebortg
Copy link
Member

@rebortg rebortg commented Sep 11, 2024

Change Summary

Implement basic node_exporter function

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T973

Related PR(s)

vyos/vyos-build#757

Component(s) name

node_exporter

Proposed changes

add new feature node_exporter with vrf support.

How to test

# use defaults:
set service monitoring node-exporter

# all config
set service monitoring node-exporter listen-address 10.10.10.1
set service monitoring node-exporter port 9999
set service monitoring node-exporter vrf mgmt

Smoketest result

vyos@vyos:~$ /usr/libexec/vyos/tests/smoke/cli/test_service_monitoring_node-exporter.py
test_01_basic_config (__main__.TestMonitoringNodeExporter.test_01_basic_config) ... ok

----------------------------------------------------------------------
Ran 1 test in 4.832s

OK

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Copy link

github-actions bot commented Sep 11, 2024

👍
No issues in PR Title / Commit Title

Copy link

github-actions bot commented Sep 11, 2024

✅ No issues found in unused-imports check.. Please refer the workflow run

@rebortg rebortg force-pushed the node_exporter branch 2 times, most recently from f23fc7b to aba505a Compare September 11, 2024 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants