Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit to 0.30 #2570

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

Conversation

Letronix624
Copy link

@Letronix624 Letronix624 commented Sep 29, 2024

Ruining each example by updating winit.

Implementation is straight forward, but examples are extreme manual labor. I'm asking for help.

If you see anything that you want different please comment.

This new version of winit has a major API change that requires a type that implements their new ApplicationHandler trait instead a single closure for the events,
splitting the previous sequenced one-function documentation of each example in 3 methods, thereby ruining each example with winit. Please advise how we can fix this. I am sorry for ruining your day.

Stays a draft as long as deprecated methods are used.

Status

  • bloom
  • image
  • teapot
  • indirect
  • deferred
  • triangle
  • offscreen
  • gl-interop
  • instancing
  • mesh-shader
  • async-update
  • multi-window
  • tessellation
  • runtime-array
  • texture-array
  • triangle-util
  • triangle-v1_3
  • runtime-shader
  • occlusion-query
  • buffer-allocator
  • push-descriptors
  • simple-particles
  • clear-attachments
  • immutable-sampler
  • interactive-fractal
  • shader-types-derive
  • image-self-copy-blit
  • multi-window-game-of-life

Changelog:

### Public dependency updates
- [winit](https://crates.io/crates/winit) 0.30

### Breaking changes
Changes to `vulkano-util`:
- `VulkanoWindows::create_window` now takes an `ActiveEventLoop` instead of an `EventLoopWindowTarget<T>`
- `VulkanoWindows::get_fitting_videomode` now returns `VideoModeHandle`
- `VulkanoWindows::get_best_videomode` now returns `VideoModeHandle`

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant