Skip to content

Commit

Permalink
Disable validate_global_variables check for now (#2593)
Browse files Browse the repository at this point in the history
  • Loading branch information
Rua authored Oct 27, 2024
1 parent 2df8003 commit 3e4ed48
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion vulkano/src/pipeline/shader/validate_runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ pub(crate) fn validate_runtime(
validator.validate_decorations()?;
validator.validate_execution_modes()?;
validator.validate_types()?;
validator.validate_global_variables()?;
// FIXME: validator.validate_global_variables()?;
validator.validate_functions()?;

Ok(())
Expand Down Expand Up @@ -1040,6 +1040,9 @@ impl<'a> RuntimeValidator<'a> {
Ok(())
}

// FIXME: this needs to use only the global variables that are statically used by the
// entry point's call tree. That requires analysing the call tree during `Spirv::new`.
#[allow(dead_code)]
fn validate_global_variables(&self) -> Result<(), Box<ValidationError>> {
let properties = self.device.physical_device().properties();

Expand Down

0 comments on commit 3e4ed48

Please sign in to comment.