Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change style plugin prefix for nuxt #328

Merged

Conversation

franz-bendezu
Copy link
Contributor

Changes

This pull request addresses the issue mentioned in #313 by making a specific and focused change to the plugin. The primary modification involves updating the prefix to resolve the sourcemap and Nuxt loading issues.

Objectives

  1. Bug Fix: Resolve the sourcemap bug caused by the \0 prefix, ensuring compatibility with Nuxt builds.
  2. Enhancement: Improve the virtual prefix for better integration with Nuxt's main pattern.

Context

The original pull request #313 aimed to achieve multiple objectives, but feedback from the maintainers highlighted the need for a more focused change. This new pull request isolates the modification to the prefix, aiming to keep the scope concise and targeted.

Related Issues

@franz-bendezu
Copy link
Contributor Author

After testing, this change successfully resolves the issue of stuck loading and adds support for inline styles via SSR. I am currently investigating the cause of the sourcemap warning during server build start.

@shawn-mty
Copy link

What's going on with this? @franz-bendezu

@shawn-mty
Copy link

shawn-mty commented May 2, 2024

@johnleider 🙏

Fixing this will help everyone who uses Nuxt. Please help🙏

#290

@franz-bendezu
Copy link
Contributor Author

What's going on with this? @franz-bendezu

I have seen more changes in the repository and I have not had time these months, on the weekend I will review it in detail

@shawn-mty
Copy link

What's going on with this? @franz-bendezu

I have seen more changes in the repository and I have not had time these months, on the weekend I will review it in detail

Thanks boss, appreciate you!

@adamskeeled
Copy link

Any updates regarding this?

@adamskeeled
Copy link

@KaelWD @johnleider Apologies for bothering you about this, but any idea when this can be reviewed and possibly merged?
Or if it's not gonna happen anytime soon, any short-term solution I can do on my side while this doesn't get merged?
Thanks in advance!

@johnleider johnleider merged commit 93fa929 into vuetifyjs:master Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants